Skip to content

Conversation

@a-b
Copy link
Member

@a-b a-b commented May 22, 2024

Description of the Change

Utilize Ginkgo v2 granular FlakeAttempts() to improve reliability of util/clissh/ssh_test.go on mac workers.

Why Is This PR Valuable?

Less false negative tests.

@a-b a-b changed the title Retry flaky ssh test on mac [v7] Improve reliability of the ssh units [v7] May 22, 2024
@a-b a-b requested a review from gururajsh May 22, 2024 09:19
@a-b a-b marked this pull request as draft May 22, 2024 09:30
- Simplified CLI SSH Suit execution to run togetheer with other non-plugin tests

https://onsi.github.io/ginkgo/#repeating-spec-runs-and-managing-flaky-specs
@a-b a-b force-pushed the 187325694-flaky-ssh-units-on-mac-v7 branch from 31d3534 to ba01412 Compare May 22, 2024 09:33
@a-b a-b marked this pull request as ready for review May 22, 2024 17:32
Copy link
Contributor

@Samze Samze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gururajsh gururajsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gururajsh gururajsh merged commit 604bb7b into v7 May 22, 2024
@a-b a-b deleted the 187325694-flaky-ssh-units-on-mac-v7 branch May 22, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants