Bump stack from cflinuxfs3 to cflinuxfs4 [v7] #3157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use CAPI release version var Remove min CAPI jobs Move ops-files from cli-ci to this repo
a-b
previously approved these changes
Aug 28, 2024
joaopapereira
approved these changes
Aug 30, 2024
Contributor
joaopapereira
left a comment
There was a problem hiding this comment.
LGTM.
Minor details to address in the future and not related specifically with this PR:
- Our examples code having real versions and stacks will force us to update them everytime they change which is a chore and maybe we can replace them with dummy values
- There is a lot of "cflinuxfs4" strings in our code, specially in tests, do we really need to have that many places where we set the stack?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace cflinuxfs3 stack references with cflinuxfs4
Use CAPI release version repository var if set. If not, get the latest CAPI version
Remove min CAPI jobs
Move ops-files from cli-ci to this repo