Update runner image to the latest ubuntu #3450
Conversation
a-b
commented
Mar 11, 2025
- Use dpkg-deb -Zxz to keep backward compatibility
- Improve test to check compatibility with Deb OSes
- Use dpkg-deb -Zxz to keep backward compatibility - Improve test to check compatibility with Deb OSes Co-authored-by: João Pereira <joao.pereira@broadcom.com> Co-authored-by: Alex Rocha <alex.rocha@broadcom.com>
| run: | | ||
| ls -R | ||
| for i in debian:11 debian:12 ubuntu:20.04 ubuntu:22.04 ubuntu; do docker run \ |
There was a problem hiding this comment.
question I dont have context on the compression issue, but how does this test it?
There was a problem hiding this comment.
dpkg --info fails when trying to open a .deb file with unsupported compression.
There was a problem hiding this comment.
Couple examples:
- red run with unsupported compression https://github.com/a-b/cli/actions/runs/13781247233/job/38539815075#step:3:30
- green run https://github.com/a-b/cli/actions/runs/13781160806/job/38539576483#step:3:29
There was a problem hiding this comment.
Can we use the matrix strategy here to change the container image? instead of this for loop?
There was a problem hiding this comment.
Good call. Yes, we should use matrix!
joaopapereira
left a comment
There was a problem hiding this comment.
I am going to approve this PR due to the urgency to get this merged so we can release but I would love if we could answer the 2 questions I left and also create a subsequent PR to address them.
| run: | | ||
| ls -R | ||
| for i in debian:11 debian:12 ubuntu:20.04 ubuntu:22.04 ubuntu; do docker run \ |
There was a problem hiding this comment.
Can we use the matrix strategy here to change the container image? instead of this for loop?