Migrate to golangci v2[v8] #3588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marckhouzam
reviewed
Sep 24, 2025
Contributor
marckhouzam
left a comment
There was a problem hiding this comment.
Thanks for doing this. Moving to 2.4 was a big step up.
A couple of minor suggestions but this looks good to me.
Member
Author
Thank you for such thorough review :) |
marckhouzam
approved these changes
Sep 24, 2025
Contributor
marckhouzam
left a comment
There was a problem hiding this comment.
A couple of follow-ups but LGTM
P.S. I don't have permissions to resolve the comments that I opened.
marckhouzam
approved these changes
Sep 26, 2025
Contributor
marckhouzam
left a comment
There was a problem hiding this comment.
Thanks for the updates. LGTM
Samze
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golangci-lint v1 is no longer supported on go 1.25. This PR migrates it from v1 to v2.