Make Jenkins and SCM plugin install and restart optional #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14931e6 to
bf94364
Compare
Add skipPlugins and skipRestart flags for Jenkins and SCM-Manager. - Update config schema and CLI options - Add env var support to feature classes - Skip plugin install and restart in init scripts - Extract SCM plugin install logic to installScmmPlugins - Add tests to verify skipping behavior Co-authored-by: Johannes Schnatterer <johannes.schnatterer@cloudogu.com>
This is the right thing to do in regard to GOP modularity. It also reduces the risk of running into this notorious error: java.lang.RuntimeException: Cannot enable authentication for prometheus: groovy.lang.MissingPropertyException: No such property: PrometheusConfiguration for class: Script1 Caused by running the Config Script on Jenkins that fails because the Prometheus APIs are missing there.
bf94364 to
4a3ea6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add skipPlugins and skipRestart flags for Jenkins and SCM-Manager.
Config:
CLI Options: