Skip to content

[surfacers.prometheus] Change include_timestamp's default behavior #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2025
Merged

[surfacers.prometheus] Change include_timestamp's default behavior #1169

merged 3 commits into from
Nov 4, 2025
+269 −137

Conversation

@manugarg
Copy link
Contributor

@manugarg manugarg commented Nov 3, 2025 •
edited
Loading

  • This PR changes the default behavior of include_timestamp config option (and of disable_metrics_expiration). We include timestamp and expire stale metrics only for gauge metrics by default. From config.proto:
  // Whether to include timestamps in metrics. By default, we include
  // timestamps only for gauge metrics as they represent the value at a certain
  // point in time.
  //
  // If explicitly enabled, timestamp will be attached to all metrics,
  // including counters. If explicitly disabled, timestamp will not be attached
  // to gauges as well.

See #1162 for more background.

@manugarg manugarg mentioned this pull request Nov 3, 2025
Closed
@manugarg manugarg added this to the v0.14.2 milestone Nov 3, 2025
@manugarg manugarg merged commit 2b701a3 into main Nov 4, 2025
12 checks passed
@manugarg manugarg deleted the prom_timestamp branch November 4, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.14.2

Development

Successfully merging this pull request may close these issues.

2 participants

@manugarg