Skip to content

Conversation

@zf2timo
Copy link
Contributor

@zf2timo zf2timo commented Apr 8, 2022

The ServerRequest requires the HTTP Method as first parameter. This was missing in the example.

zf2timo added 2 commits April 8, 2022 14:00
The ServerRequest requires the HTTP Method as first parameter. This was missing in the example.
The HTTP Method verb is also in `\Acme\Tests\Todo\UserControllerTest` missing
@clue clue added the documentation Improvements or additions to documentation label Apr 9, 2022
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zf2timo Thank you for filing this PR! May I ask you to squash your changes into single commit? Changes LGTM otherwise :shipit:

zf2timo and others added 2 commits April 12, 2022 20:14
The ServerRequest requires the HTTP Method as first parameter. This was missing in the example.

docs(testing): Added HTTP Method

The HTTP Method verb is also in `\Acme\Tests\Todo\UserControllerTest` missing
@zf2timo
Copy link
Contributor Author

zf2timo commented Apr 12, 2022

There went something wrong while squashing the commits. I will send a new PR.

@clue
Copy link
Owner

clue commented Apr 14, 2022

Closed via #143.

(For future reference: We're also happy to help if something went wrong with squashing to avoid any duplicate PRs)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants