Fix stringop-truncation warning #1473
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with gcc 15.2.1 I get the following warning: pl_env.c:198:17: warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation].
Having a look at the code, it seems that strncpy is used to copy a string where the specified length equals the source string length, resulting in no null terminator being written. The code is explicitly handing the string construction in this case, adding delimiters and a final null terminator later. So the null-padding behaviour of strncpy is not really needed and we should directly use memcpy instead to fix the truncation warning.