Skip to content

Static Data Handling #57

Open
Open

Description

@cnguy

Tags proposed by user (Djinnes).

This issue will reimplement the old functionality provided by static data (tags) where the feature will do the following:

  • cache individual data by id + params (which can be defined as a URL)
// Flashback to KindredAPI code
const rakanConfig = {
  id: 497,
  options: {
    tags: ['image', 'sanitizedDescription']
  },
  region: REGIONS.BRAZIL
}

k.Static.champion(rakanConfig)
        .then(data => console.log(data))
        .catch(err => console.error(err))

I forgot what the resulting JSON loos like but you get the point

This issue needs rewriting

Before starting on this, it might be a good idea to have some example JSON outputs given some tags.
Note that version and locale used to be tags but is actually already implemented through DDragon urls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions