-
Notifications
You must be signed in to change notification settings - Fork 477
Archive v20.1 #21416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Archive v20.1 #21416
Conversation
- Delete v20.1 directory and related files - Remove _includes/releases/v20.1/ and _includes/v20.1/ directories - Update releases/v20.1.md to archived format with support policy links - Add all 27 v20.1 release anchors to prevent broken links - Fix cross-version references pointing to v20.1 - Archive follows v2.1 pattern: page exists but shows archived notice
- Copy DBeaver and IntelliJ images from v2.1 to v20.1 directory - Update image links in dbeaver.md and intellij-idea.md to use v20.1 images - Update sidebar_htmltest.rb to respect htmltest config and skip archived versions Addresses cross-version linking issues similar to those fixed in PR #21195
Files changed:
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
rmloveland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small changes, should go in easily after #21195 merges
|
|
||
| module SidebarHTMLTest | ||
| class Generator < Jekyll::Generator | ||
| def generate(site) | ||
| @site = site | ||
|
|
||
| # Read htmltest configuration to get ignored directories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we adding v20.1 images to the repo in this PR? this PR is supposed to remove v20.1 stuff
I suspect you need these images to generate the archive. Is that correct?
If so, this may provide an argument for generating the archive zip for each version before deleting that version from the repo.
src/current/v20.1/cockroach-sql.md
Outdated
| {% include {{ page.version.version }}/sql/connection-parameters.md %} | ||
|
|
||
| See [Client Connection Parameters](connection-parameters.html) for more details. | ||
| See [Client Connection Parameters](connection-parameters.html) for connection details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file needs to be deleted
| }, | ||
| { | ||
| "title": "Support Resources", | ||
| "title": "DBeaver", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file needs to be deleted - also the v20.1 files it's pointing to (DBeaver, IntelliJ, etc)
rmloveland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ebembi-crdb this LGTM once you implement the changes I mentioned in the comments. Wanted to unblock you on this since I will be on PTO for the holidays next week
- Add v20.1 offline documentation link to archived documentation page - Remove v20.1 specific files from repository including: - src/current/v20.1/ directory - src/current/_includes/sidebar-data-v20.1.json - src/current/images/v20.1/ directory - Resolve merge conflicts with main branch
Remove link to v20.1.md#v20-1-0-beta-3-changes-to-operational-workflows in certificate-based authentication doc since v20.1 is now archived
Archives v20.1 documentation following the same process used for v2.1.