WIP: Reworking network configuration to use kickstart commands as much as possible #3941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
8274627 to
051391c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Items
Fixes #3409 #3406 #1881
Description
Current network config for "complicated" network configuration relies heavily on generating ifcfg files in post_install_network_config. ifcfg files have been deprecated for a long time and I think are essentially gone as of EL10. So, we should try to make use of anaconda's network configuration as much as possible, and nmcli where it is not.
This is an initial step in that direction.
One note - for a long time anaconda's network --dev option can accept a MAC address instead of a device id. For now at least I've left in place cobbler's code to see if a MAC address exists on the machine. I'm not yet sure which would be the best approach.
Behaviour changes
Old:
network_configwould either generate some basic network config if no MAC addresses were present, otherwise would include config generated in %pre bypre_install_network_config.post_install_network_configwould generate some more complicated network configsNew:
network_configsimply includes the network config generated bypre_install_network_config. This moves configuration into one place and allows use to see what devices actually exist on the system.Currently this adds support for basic bridges in the anaconda config and for vlans (untested).
TODO: routing. Others?
Category
This is related to a:
Tests
I'm not sure what the state of current tests if any are in this area. Pointers welcome.