Skip to content

feat: Implement pharaoh framework #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codekeyz merged 8 commits into from
Mar 5, 2024
Merged

feat: Implement pharaoh framework #120

codekeyz merged 8 commits into from
Mar 5, 2024

Conversation

@codekeyz
Copy link
Owner

@codekeyz codekeyz commented Mar 4, 2024

Description

This PR introduces a Class-Based backend development in addition to purely being functions. Also adds on a nice layer for elegant routing, request validation etc.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codekeyz codekeyz added the enhancement New feature or request label Mar 4, 2024
@codekeyz codekeyz self-assigned this Mar 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 63.49892% with 169 lines in your changes are missing coverage. Please review.

Project coverage is 71.34%. Comparing base (400cd9e) to head (1973e88).

Files Patch % Lines
packages/pharaoh/lib/next/_core/reflector.dart 46.57% 39 Missing ⚠️
packages/pharaoh/lib/next/http.dart 4.16% 23 Missing ⚠️
packages/pharaoh/lib/next/_core/config.dart 24.00% 19 Missing ⚠️
packages/pharaoh/lib/next/router.dart 62.00% 19 Missing ⚠️
packages/pharaoh/lib/next/_router/definition.dart 70.96% 18 Missing ⚠️
packages/pharaoh/lib/next/_core/core_impl.dart 26.08% 17 Missing ⚠️
packages/pharaoh/lib/next/core.dart 76.81% 16 Missing ⚠️
packages/pharaoh/lib/next/_core/container.dart 0.00% 7 Missing ⚠️
packages/pharaoh/lib/next/_router/meta.dart 88.33% 7 Missing ⚠️
packages/pharaoh/lib/next/_validation/dto.dart 80.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
- Coverage   74.44%   71.34%   -3.10%     
==========================================
  Files          34       47      +13     
  Lines        1119     1574     +455     
==========================================
+ Hits          833     1123     +290     
- Misses        286      451     +165

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codekeyz codekeyz force-pushed the feature/implement-pharaoh-framework branch from 017cce5 to 1973e88 Compare March 4, 2024 23:15
@codekeyz codekeyz merged commit 7186055 into main Mar 5, 2024
@codekeyz codekeyz deleted the feature/implement-pharaoh-framework branch March 5, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@codekeyz codekeyz

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@codekeyz @codecov-commenter