using stopwords-iso JSON to cover more languages #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
FYI, in the case you want to off-loading some of the stopwords loading code, You can https://pypi.org/project/stopwordsiso/ This way, there's a possibility that we don't have to maintain some of the stopwords-xx.txt inside newspaper and just rely on stopwords-iso JSON file (I'm not sure anyway if it's a good idea or not, well, in terms of control over the behavior of newspaper). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds ~30 languages, and uses an easily updatable source of stopwords from stopwords-iso rather than requiring separately maintained stopwords files. I switched over every language that's in stopwords-iso to use that, so there may be some differing results, but overall there should be similar performance. (https://github.com/stopwords-iso/stopwords-iso).
This PR leaves the
.txtloading functionality (since Macedonianmkwasn't in stopwords-iso), but a side effect is that users may still include.txtfiles in theresources/textdirectory to add languages.