Included 'span' and 'a' #635
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes author names are included inside span and a. So modified the code. Can also include div if necessary
Often author name is included in text of 'span' and 'a'. So author name is searched there too
Owner
|
Great find @agnelvishal, looking!! 💯👍 |
codelucas
reviewed
Oct 26, 2018
Owner
codelucas
left a comment
There was a problem hiding this comment.
see comments, this is a great change but have some suggestions
newspaper/extractors.py
Outdated
| if match.tag == 'meta' or match.tag == 'span' or match.tag == 'a': | ||
| mm = match.xpath('@content') | ||
| if not mm: | ||
| mm=str(match.text_content()).split() |
Owner
There was a problem hiding this comment.
Confident that this will increase the recall but will precision take a hit?
I am going to approve this but can you also add some urls where you found that these changes were helpful
newspaper/extractors.py
Outdated
| if match.tag == 'meta' or match.tag == 'span' or match.tag == 'a': | ||
| mm = match.xpath('@content') | ||
| if not mm: | ||
| mm=str(match.text_content()).split() |
Owner
There was a problem hiding this comment.
nit: python style, please add spaces between the = on line 154
Contributor
Author
|
newspaper/newspaper/extractors.py Line 159 in b75b9c7 if len(content) > 0 and len(content) < 30: to get better precision.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes author names are included inside span and a. So modified the code.
Can also include div if necessary