Previous siblings were inserted in reverse order #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Added tests |
…add_siblings_wrong_order_fix
…to add_siblings_wrong_order_fix # Conflicts: # tests/unit_tests.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_siblings()adds previous node siblings (which were also scored as good elements) before top_node.Usually, such nodes don't exist or there is only one node, which is previous sibling of top_node and has good score. So this code worked well in many cases. But if we have more than one such node, the bug appears because node elements are inserted always at first position in a list
top_node.insert(0, p), so first element becomes last and vise versa.It was hard to catch this bug, 70 web pages from different domains just passed all my tests with this fix and without it.
I will add tests later,