Skip to content

Added in proxy feature#40

Merged
codingo merged 4 commits into
masterfrom
proxy-feature
May 28, 2019
Merged

Added in proxy feature#40
codingo merged 4 commits into
masterfrom
proxy-feature

Conversation

@prodigysml

Copy link
Copy Markdown
Collaborator

No description provided.

@prodigysml prodigysml requested a review from codingo May 28, 2019 02:47
@prodigysml prodigysml added the enhancement New feature or request label May 28, 2019
Comment thread Interlace/lib/core/input.py Outdated

final_commands = InputHelper._replace_variable_array(final_commands, "_proxy_", proxy_list)

print(final_commands)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this leftover debug code?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

referring to: print(final_commands)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! Woops! I'll remove that now!


# process proxies
if arguments.proxy_list:
proxy_list = list()

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about passing all of this through a set to strip out duplicates? I'm unsure, I wonder if some people will intentionally want multiple copies of one proxy (to favor it over others)?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done intentionally so that in case you have 10 proxies and 100 targets, we can reuse the 10. Also, this allows a tester to weight their proxies as per the load required. Say I have 5 proxies, and I want 1 proxy to take a majority of the load, so I'll add the proxy an extra 3 times to the file.

@codingo codingo self-assigned this May 28, 2019
@codingo

codingo commented May 28, 2019

Copy link
Copy Markdown
Owner

Final changes needed for readme.me updated and version increment then good to land!

@codingo codingo merged commit 4223d29 into master May 28, 2019
@codingo codingo deleted the proxy-feature branch June 4, 2019 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants