Add rate limiting - Untested#40
Merged
Merged
Conversation
Owner
|
Not ignoring either of these - going to have to build out a new test case for them so will review in 24 hours. |
codingo
approved these changes
Sep 30, 2017
codingo
left a comment
Owner
There was a problem hiding this comment.
A number of changes to master since this was committed meant some merging was necessary but on the whole this looks good and ready for commit.
Owner
|
Hi @grimd34th I've fixed a number of issues to bring this back up to date with master however in testing it doesn't appear to sleep (I've tried passing numerous values). Could you revisit the code in its new state and see if you can figure out why? |
Owner
|
Disregard - fixed. Bug was introduced by me when I did the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a sleep after the function call with python's standard time.sleep and a default of 0 and a command line option to set the limit