This repository was archived by the owner on Mar 4, 2024. It is now read-only.
[FIX] Refactor CloudHsmV2 Resource #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3298b15 to
f509a7c
Compare
This refactors the HSM resource so that we don't have to hardcode the cluster ID and subnet ID in the HSM resource, and instead can use terraform references for those values.
f509a7c to
297e2b7
Compare
mudlark
approved these changes
Dec 5, 2019
|
Review Error for mudlark @ 2019-12-05 16:14:41 UTC |
mudlark
approved these changes
Dec 5, 2019
|
Review Error for mudlark @ 2019-12-05 16:16:01 UTC |
mudlark
approved these changes
Dec 5, 2019
|
Review Error for mudlark @ 2019-12-05 16:21:50 UTC |
mudlark
approved these changes
Dec 5, 2019
|
Review Error for mudlark @ 2019-12-05 16:23:24 UTC |
|
Review Error for somic @ 2019-12-05 16:31:23 UTC |
mudlark
approved these changes
Dec 5, 2019
|
Review Error for somic @ 2019-12-05 16:37:50 UTC |
aarti
approved these changes
Dec 5, 2019
|
Review Error for aarti @ 2019-12-05 16:39:24 UTC |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the HSM resource so that we don't have to hardcode the
cluster ID and subnet ID in the HSM resource, and instead can use
terraform references for those values.