Fast unions#1026
Merged
Merged
Conversation
Collaborator
|
This looks great! I'll take a better look tomorrow and try to think of possible unintended implications. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay, one more for fun I guess.
Right now Zod's unions work by evaluating all options and returning the first valid result, the first dirty result, or an error. So, the performance of a union check is strictly related to the possible options.
This changes the (sync) union mechanism to instead succeed fast. If the first option works, then it returns immediately. In the success case, this means that
z.unioncan be faster than evaluating all the options. That's basically it. Also, it's a little more stingy with how it uses memory, by retaining less of results.