Coverage: Add tests for uncovered default branches #2947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f3c7e66 to
16822d3
Compare
3 tasks
914372b to
6cd9d40
Compare
- Add and update `test_fuzz_hooks` across relevant modes to ensure complete coverage of safety hook logic. - Iterate through specific message IDs, safety parameters (e.g., EV/Hybrid flags), and all CAN buses (0-2) to explicitly cover all branches of `if-else` ID and bus checks. - Verify default/else branches by fuzzing unknown addresses.
6cd9d40 to
776a4c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes incremental progress towards #2944. In this parent PR, I create 6 helper functions in C to directly call rx hooks, bypassing the whitelists which would usually prevent these invalid calls from going through. The helper functions are then used to thoroughly test rx and tx hooks in various modes. These changes were made after discussing my previous attempt at improving branch coverage with Adeeb in the dev call. After some deliberation, I found that it is simpler to test the empty
elsebranches than to try to remove them cleanly. If all the related PRs are merged, this PR should have no diff and could be closed.These changes have all been broken out into individual PRs by mode:
Verification
opendbc/safety/tests/test.sh --report(with branch coverage enabled) on master:Overall branch coverage: 92.2%
opendbc/safety/tests/test.sh --reporton this branch:Overall branch coverage: 95.6%