setup proper pip package #2278
setup proper pip package #2278
Conversation
|
not ready for review |
|
Converting to draft until it's ready for review |
|
ready now, openpilot pr: commaai/openpilot#36185 |
MANIFEST.in
Outdated
| include SConstruct | ||
| include SConscript |
There was a problem hiding this comment.
don't think we need these two?
There was a problem hiding this comment.
why do we need this? we should only add top level files/dirs if absolutely needed
There was a problem hiding this comment.
py.typed is required by [PEP 561] without it, type checkers like mypy treat everything as Any.
pyproject.toml
Outdated
|
|
||
| [build-system] | ||
| requires = ["setuptools>=61", "wheel"] | ||
| requires = ["setuptools>=61", "wheel", "pycryptodome >= 3.9.8", "scons", "opendbc @ git+https://github.com/commaai/opendbc.git@master#egg=opendbc",] |
There was a problem hiding this comment.
no way to use the dependencies declared above?
There was a problem hiding this comment.
I tried, based on my reading [project].dependencies includes deps that are required after the build whereas [build-system].requires includes deps required before the build, and as per my knowledge there is no place where we can mention deps that are common to both of these environments...these are treated as two completely different enviroments.
pyproject.toml
Outdated
| [tool.hatch.build.targets.wheel] | ||
| packages = ["src/panda"] | ||
| include = [ "include/**" | ||
| ] |
There was a problem hiding this comment.
cleanup the formatting
| [tool.hatch.build.targets.wheel.shared-data] | ||
| "include" = "include" | ||
|
|
||
| [tool.setuptools.package-data] |
There was a problem hiding this comment.
isn't this redundant with MANIFEST.in?
| from setuptools.command.build import build as _build | ||
|
|
||
| class build(_build): | ||
| def run(self): |
setup.py
Outdated
| class build(_build): | ||
| def run(self): | ||
| env = os.environ.copy() | ||
| env['FINAL_PROVISIONING'] = '1' |
There was a problem hiding this comment.
this should not be set
|
@adeebshihadeh any comments? |
|
@adeebshihadeh pinging again |
sets up a proper pip package, a .whl build for openpilot to use out of the box. includes .h and .py from the board dir, includes .py files from python dir.
issue: #2239
here all the files included in the build