[runtime/network/tokio] Use BufReader for read buffering
#2595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying monorepo with
|
| Latest commit: |
474535d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9d394f22.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://cl-buf-reader-alt.monorepo-eu0.pages.dev |
dc176c4 to
b7e0d6e
Compare
b7e0d6e to
742f33e
Compare
patrick-ogrady
approved these changes
Dec 20, 2025
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #2595 +/- ##
==========================================
- Coverage 92.64% 92.62% -0.02%
==========================================
Files 353 353
Lines 102339 102534 +195
==========================================
+ Hits 94810 94977 +167
- Misses 7529 7557 +28
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #786
Overview
Alternative for #2593, but using
tokio'sBufReaderrather than implementing our own read buffering.