Check if entry name is the same as CLI config name #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #48 , the reason why we are not forcing file name to be the one written in config is simply because we might need to provide the flexibility to create alias when there are name conflicts in CLIs, e.g developer could potentially provide alternative file name to install a given command, which is like
file
foo-darkexecutes thefoocommandfile
fooexecutes anotherfoocommandthis should make sense. So now we will let people to make sure their file name is the same as entry command name at interface level. The implementation of this part is likely to change due to this feature.
cc: hope this work for you @mehalter