Skip to content

Support weakdeps #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Roger-luo merged 4 commits into from
Sep 11, 2023
Merged

Support weakdeps #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7834ed7
Support weakdeps
qiaojunfeng Sep 4, 2023
3d5aedb
Test weakdeps
qiaojunfeng Sep 5, 2023
78f3dd5
Add to `extras` for compatibility with Julia 1.6
qiaojunfeng Sep 7, 2023
2cc3820
Add `extras`
qiaojunfeng Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions example/FakePkg/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,12 @@ Comonicon = "863f3e99-da2a-4334-8734-de3dacbe5542"
FromFile = "ff7dd447-1dcb-4ce3-b8ac-22a812192de7"
PkgTemplates = "14b8a8f1-9102-5b29-a752-f990bacb7fe1"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[weakdeps]
DelimitedFiles = "8bb1440f-4735-579b-a4ab-409b98df4dab"

[compat]
DelimitedFiles = "1"

[extras]
DelimitedFiles = "8bb1440f-4735-579b-a4ab-409b98df4dab"
6 changes: 6 additions & 0 deletions src/builder/sysimg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@ function create_command_env(m::Module, envpath::String = mktempdir(); test_deps:
cmd_project = Pkg.Types.Project()
merge!(cmd_project.deps, ctx.env.project.deps)
merge!(cmd_project.compat, ctx.env.project.compat)
if hasproperty(ctx.env.project, :extras)
merge!(cmd_project.extras, ctx.env.project.extras)
end
if hasproperty(ctx.env.project, :weakdeps)
merge!(cmd_project.weakdeps, ctx.env.project.weakdeps)
end
# add the package to dependencies
cmd_project.deps[ctx.env.project.name] = ctx.env.project.uuid

Expand Down