chore: add voting power validation (v0.38.x) #5520
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validates voting power and returns an error instead of panicking
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code commentsNote
Switch total voting power computation to return errors instead of panicking, add a safe accessor, and update callers/tests accordingly.
types/validator_set.go):updateTotalVotingPower()to returnerrorinstead of panicking on overflow and settotalVotingPower.TotalVotingPowerSafe()to get TVP with error handling.TotalVotingPower()to panic only ifupdateTotalVotingPower()returns an error.updateWithChangeSet(),ValidatorSetFromProto()(now returns error on bad input), andValidatorSetFromExistingValidators().types/validator_set_test.go):TestValidatorSetFromProtoReturnsErrorOnOverflowto assert error on TVP overflow from proto input.verifyValidatorSet()to handleupdateTotalVotingPower()error.Written by Cursor Bugbot for commit a66f19f. This will update automatically on new commits. Configure here.