-
Notifications
You must be signed in to change notification settings - Fork 11.1k
Only show image files in LoadImage file select combo #7573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only show image files in LoadImage file select combo #7573
Conversation
|
Don't forget about the LoadImageMask node too. Though I'm not sure if it accepts any special types. |
|
Question: Should a separate node perhaps be created for loading video? I don't know if loadimage supports automatic frame splitting (I always use VHS), but if it does then the filter will disable the vanilla ability to do that. |
Yes, eventually we will have that. But currently we don't have nodes that take video input (only leaf nodes that output video), so there's no reason to have a loader for it. The frontend has already been changed to support video loader nodes once we have reason to add one. |
|
Hum, odd; Don't hunyuan and wan fun have V2V, with native support? |
Not to my knowledge. How is V2V done natively at the moment? If there's a reason to add a LoadWEBM or LoadVideo node then I'd love to add it. |
Ah, I see what I did back in hun for V2V: It's set to load up a webp (genned in T2V) using native load image, resize image and vae tile encode to latent, then pass to a standard custom sampler. It's quite possible I never actually used an mp4 directly - apparently that yields "cannot identify image file" error as you say, so I couldn't have successfully. Though if there were such a video load node converting it to an image batch as VHS does, that could make the extension redundant for basic V2V (though tbf without ffmpeg's universal format support, it's not great). |
Filter out non-images from the file selection list in LoadImage node, as there is starting to be more video and 3d model files in the input folder which can cause issues if accidentally selected (e.g., when using the arrow buttons on the combo widget).
LoadAudio node uses same filtering function for past 7 months (since #4054) without reported bugs:
ComfyUI/comfy_extras/nodes_audio.py
Line 218 in 22ad513