Skip to content

fix(user_manager): fix typo in move_userdata dest validation #10967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kosinkadink merged 1 commit into from
Nov 28, 2025
Merged

fix(user_manager): fix typo in move_userdata dest validation #10967

Kosinkadink merged 1 commit into from
Nov 28, 2025

Conversation

@ltdrdata
Copy link
Collaborator

@ltdrdata ltdrdata commented Nov 28, 2025

Check dest instead of source when validating destination path in move_userdata endpoint.

@ltdrdata
fix(user_manager): fix typo in move_userdata dest validation
490b51b 
Check `dest` instead of `source` when validating destination path
in move_userdata endpoint.
christian-byrne
christian-byrne approved these changes Nov 28, 2025
View reviewed changes
Copy link
Collaborator

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Before:

ComfyUI/app/user_manager.py

Lines 422 to 428 in 52e778f

source = get_user_data_path(request, check_exists=True)
if not isinstance(source, str):
return source
dest = get_user_data_path(request, check_exists=False, param="dest")
if not isinstance(source, str):
return dest

@Kosinkadink Kosinkadink merged commit ca7808f into comfyanonymous:master Nov 28, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kosinkadink Kosinkadink Kosinkadink approved these changes

@christian-byrne christian-byrne christian-byrne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ltdrdata @Kosinkadink @christian-byrne