feat: CPLYTM-900 CPLYTM-899 dry run logic #229
Conversation
a1bfa4d to
aafde25
Compare
bb135cd to
8f6c26f
Compare
8f6c26f to
d18def1
Compare
jpower432
left a comment
There was a problem hiding this comment.
Thanks @hbraswelrh. Added a couple initial comments.
internal/complytime/scope.go
Outdated
| } | ||
| } | ||
|
|
||
| remarksProps := extractRemarksProperties(cds) |
There was a problem hiding this comment.
Is it possible any of the property parsing logic (especially for OSCAL Compass extenstions) could live upstream in oscal-sdk-go? It seems the NewAssessmentScopeFromCDs is performing a lot of manual Component Definition parsing that could be generally useful. Not a blocker for this PR, but I think might be worth looking at in a follow on from a technical debt perspetive.
There was a problem hiding this comment.
I think this is a very good point. Updating oscal-sdk-go with the introduced property parsing logic would be beneficial for maintainability and decoupling. I could propose a task for evaluating complyctl and decoupling through an upstream PR. WDYT?
cd257d7 to
8384a39
Compare
67be64b to
667e95a
Compare
8b1a0cb to
66028de
Compare
Signed-off-by: Hannah Braswell <hbraswel@redhat.com>
Signed-off-by: Hannah Braswell <hbraswel@redhat.com>
Signed-off-by: Hannah Braswell <hbraswel@redhat.com>
66028de to
57f8fe3
Compare
Summary
This PR updates the existing
--dry-runlogic for thecomplyctl plancommand. TheselectParametersYAML key was added to inform the user of the parameters that are available in their assessment plan when passing the--dry-runflag. The included controls of the assessment plan will have their ownselectParametersYAML key that hasnameandvaluefor each of the parameterIDs that are associated with the control ID.Several functions were added to maintain the
NewAssessmentScopeFromCDsfactory functionality. The smaller functions build around theNewAssessmentScopeFromCDsto help separate parsing and processing the control implementations.Related Issues
Review Hints
./bin/complyctl plan <framework-id> --dry-runconfig.ymlusing the command:./bin/complyctl plan <framework-id> --dry-run --out config.ymlExample: