Skip to content

chore: [CPLYTM-1018] remove placeholders #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
huiwangredhat merged 1 commit into from
Sep 25, 2025
Merged

chore: [CPLYTM-1018] remove placeholders #286

huiwangredhat merged 1 commit into from
Sep 25, 2025

Conversation

@huiwangredhat
Copy link
Member

@huiwangredhat huiwangredhat commented Sep 23, 2025

Summary

The placeholders, "REPLACE_ME", in assessment-plan and assessment-result will be replaced with a meaningful string.

Related Issues

CPLYTM-1019

Review Hints

  • In the assessment-plan.json, there are 4 placeholders:
 assessment-plan.assessment-assets.assessment-platforms.title
 assessment-plan.assessment-assets.import-ssp.href
 assessment-plan.assessment-assets.back-matter.resources.description
 assessment-plan.metadata.title
  • In the assessment-result.json, there is one placeholder:
    assessment-results.metadata.title.
  • The assessment-plan.json and assessment-result.json has no REPLACE_ME after the PR.

@huiwangredhat huiwangredhat marked this pull request as ready for review September 23, 2025 08:45
@huiwangredhat huiwangredhat requested a review from a team as a code owner September 23, 2025 08:45
hbraswelrh
hbraswelrh requested changes Sep 23, 2025
View reviewed changes
Copy link
Member

@hbraswelrh hbraswelrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit. Once the spelling update is made the PR will be approved from my side. Nice job!

@huiwangredhat huiwangredhat force-pushed the update_placeholders branch 2 times, most recently from a95eea3 to 17bbef4 Compare September 23, 2025 14:05
hbraswelrh
hbraswelrh previously approved these changes Sep 23, 2025
View reviewed changes
Copy link
Member

@hbraswelrh hbraswelrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested with complyctl plan and the changes work properly.

"assessment-platforms": [                                                      
{
           "title": "The AssessmentPlatforms title has not been set.",              
           "uses-components": [
            {

AlexXuan233
AlexXuan233 reviewed Sep 24, 2025
View reviewed changes
@huiwangredhat
chore: [CPLYTM-1018] remove placeholders
770461e 
Signed-off-by: Sophia Wang <huiwang@redhat.com>
@huiwangredhat
Copy link
Member Author

huiwangredhat commented Sep 24, 2025

@AlexXuan233 @hbraswelrh Would you like to review it again？Thank you.

hbraswelrh
hbraswelrh approved these changes Sep 24, 2025
View reviewed changes
Copy link
Member

@hbraswelrh hbraswelrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

AlexXuan233
AlexXuan233 approved these changes Sep 25, 2025
View reviewed changes
Copy link
Member

@AlexXuan233 AlexXuan233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huiwangredhat huiwangredhat merged commit d955ea2 into complytime:main Sep 25, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexXuan233 AlexXuan233 AlexXuan233 approved these changes

@hbraswelrh hbraswelrh hbraswelrh approved these changes

@marcusburghardt marcusburghardt Awaiting requested review from marcusburghardt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huiwangredhat @AlexXuan233 @hbraswelrh