Skip to content

Conversation

@helhum
Copy link
Contributor

@helhum helhum commented Jun 26, 2023

Fixes: #11519

@helhum helhum force-pushed the feature/composer-repo-local-path branch from 69953c3 to 30e047d Compare June 26, 2023 10:50
@Seldaek Seldaek added this to the 2.6 milestone Jul 1, 2023
@dzuelke
Copy link
Contributor

dzuelke commented Jul 5, 2023

FWIW, this already works if you use file:// explicitly, but not for relative paths, which makes sense given how file:// is specced in its RFC.

I'd suggest adding a test or three for this (test file:///absolute/path, /absolute/path, ./relative/path).

@helhum
Copy link
Contributor Author

helhum commented Jul 5, 2023

FWIW, this already works if you use file:// explicitly.

Yes, but not with relative paths. And I can't specify absolute file paths in a composer.json file

@dzuelke
Copy link
Contributor

dzuelke commented Jul 5, 2023

FWIW, this already works if you use file:// explicitly.

Yes, but not with relative paths. And I can't specify absolute file paths in a composer.json file

Sorry, was still editing that comment ;)

@Seldaek Seldaek merged commit 68b7a07 into composer:main Jul 18, 2023
@Seldaek
Copy link
Member

Seldaek commented Jul 18, 2023

Thanks

@helhum
Copy link
Contributor Author

helhum commented Jul 19, 2023

Thanks

Thank you!

dzuelke added a commit to heroku/heroku-buildpack-php that referenced this pull request Oct 27, 2023
Since Composer 2.6, relative local paths are possible for repositories of type composer: composer/composer#11526
dzuelke added a commit to heroku/heroku-buildpack-php that referenced this pull request Oct 27, 2023
Since Composer 2.6, relative local paths are possible for repositories of type composer: composer/composer#11526
dzuelke added a commit to heroku/heroku-buildpack-php that referenced this pull request Nov 29, 2023
Since Composer 2.6, relative local paths are possible for repositories of type composer: composer/composer#11526
robinwo pushed a commit to robinwo/heroku-buildpack-php that referenced this pull request Sep 13, 2024
Since Composer 2.6, relative local paths are possible for repositories of type composer: composer/composer#11526
robinwo pushed a commit to robinwo/heroku-buildpack-php that referenced this pull request Sep 13, 2024
Since Composer 2.6, relative local paths are possible for repositories of type composer: composer/composer#11526
robinwo pushed a commit to robinwo/heroku-buildpack-php that referenced this pull request Sep 13, 2024
Since Composer 2.6, relative local paths are possible for repositories of type composer: composer/composer#11526
robinwo pushed a commit to robinwo/heroku-buildpack-php that referenced this pull request Sep 13, 2024
Since Composer 2.6, relative local paths are possible for repositories of type composer: composer/composer#11526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow relative local directory for repositories of type composer

3 participants