Fix the mtime of the vendor folder when running composer install #11593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When splitting the logic between the lock file management and the vendor folder management in composer 2.0, the logic playing nice with make was broken by running the logic based on operations performed in the lock file instead of operations performed in the vendor folder.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When splitting the logic between the lock file management and the vendor folder management in composer 2.0, the logic playing nice with make was broken by running the logic based on operations performed in the lock file instead of operations performed in the vendor folder.
See https://github.com/composer/composer/pull/8529/files#r367302603 for a previous discussion about this feature giving the context.