revision_mode = 'scm_folder': Only check if conanfile_path is dirty#14330
Merged
memsharded merged 1 commit intoJul 19, 2023
Conversation
memsharded
approved these changes
Jul 19, 2023
memsharded
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks very much!
Member
|
Merged for next 2.0.9, thanks again for your contribution |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Allow repository being dirty outside of
conanfile.pyfolder when usingrevision_mode = "scm_folder".Docs: omit
Hi!
I thought that it makes more sense to check
git statusonly for current directory, as Conan needs only that directory to calculate its revision. I usually have quite a dirty repo, and don't really like that Conan chokes on it :)