Skip to content

fixed wrong servers 200 ok#16126

Merged
czoido merged 3 commits into
conan-io:develop2from
memsharded:fix/servers_200_ok_wrong
Apr 23, 2024
Merged

fixed wrong servers 200 ok#16126
czoido merged 3 commits into
conan-io:develop2from
memsharded:fix/servers_200_ok_wrong

Conversation

@memsharded

@memsharded memsharded commented Apr 22, 2024

Copy link
Copy Markdown
Member

Changelog: Fix: Improve error message when one URL is not a valid server but still returns 200-ok under a Conan "ping" API call.
Docs: Omit

Close #16104

@memsharded memsharded requested a review from uilianries April 22, 2024 13:20
@memsharded memsharded added this to the 2.3.0 milestone Apr 22, 2024
@uilianries

This comment was marked as outdated.

Comment thread conans/client/rest/rest_client_common.py Outdated
memsharded and others added 2 commits April 22, 2024 16:20
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

@uilianries uilianries left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks much better:

conan create .                                                                                                                                                                                                                   08:49:32

======== Exporting recipe to the cache ========
foo/0.1.0: Exporting package recipe: /private/tmp/foo/conanfile.py
foo/0.1.0: Copied 1 '.py' file: conanfile.py
foo/0.1.0: Copied 1 '.txt' file: CMakeLists.txt
foo/0.1.0: Copied 1 '.h' file: foo.h
foo/0.1.0: Copied 1 '.cpp' file: foo.cpp
foo/0.1.0: Exported to cache folder: /tmp/conan/p/foo748e6e2c1494a/e
foo/0.1.0: Exported: foo/0.1.0#b3e7a77cdd77deb2b9ffdaa6fd368fab (2024-04-23 06:49:35 UTC)

======== Input profiles ========
Profile host:
[settings]
arch=armv8
build_type=Release
compiler=apple-clang
compiler.cppstd=gnu17
compiler.libcxx=libc++
compiler.version=15
os=Macos

Profile build:
[settings]
arch=armv8
build_type=Release
compiler=apple-clang
compiler.cppstd=gnu17
compiler.libcxx=libc++
compiler.version=15
os=Macos


======== Computing dependency graph ========
zlib/1.3.1: Not found in local cache, looking in remotes...
zlib/1.3.1: Checking remote: bincrafters
Graph root
    cli
Requirements
    foo/0.1.0#b3e7a77cdd77deb2b9ffdaa6fd368fab - Cache
ERROR: Package 'zlib/1.3.1' not resolved: Remote https://bincrafters.jfrog.io/artifactory/api/conan/public-conan doesn't seem like a valid Conan remote. [Remote: bincrafters].

@czoido czoido merged commit e6bfadb into conan-io:develop2 Apr 23, 2024
@memsharded memsharded deleted the fix/servers_200_ok_wrong branch April 23, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Bad UX when trying to fetch deactivated Artifactory

4 participants