Add doctstring for SBOM#17756
Closed
ErniGH wants to merge 10 commits into
Closed
Conversation
memsharded
approved these changes
Feb 12, 2025
memsharded
reviewed
Feb 12, 2025
memsharded
reviewed
Feb 12, 2025
czoido
reviewed
Feb 12, 2025
czoido
reviewed
Feb 12, 2025
Co-authored-by: James <memsharded@gmail.com>
Co-authored-by: James <memsharded@gmail.com>
Co-authored-by: James <memsharded@gmail.com>
Co-authored-by: James <memsharded@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
czoido
reviewed
Feb 12, 2025
czoido
reviewed
Feb 12, 2025
| @@ -3,6 +3,28 @@ | |||
| def cyclonedx_1_4(graph, name=None, add_build=False, add_tests=False, **kwargs): | |||
| """ | |||
| (Experimental) Generate cyclone 1.4 sbom with json format | |||
Contributor
There was a problem hiding this comment.
I think I would change this too, to:
(Experimental) Generate a CycloneDX 1.4 SBOM in JSON format.
czoido
reviewed
Feb 12, 2025
czoido
reviewed
Feb 12, 2025
czoido
reviewed
Feb 12, 2025
memsharded
reviewed
Feb 12, 2025
memsharded
left a comment
Member
There was a problem hiding this comment.
I have realized...
All of our conan.tools get the conanfile as first argument for a reason: This is the way that future tools.xxxx configuration via conf can be passed, as well as some internal helpers like the http requester. This might need a change to the signature of the function, to discuss:
- Add conanfile as first argument, even if it is not needed today
- Add
graphas the second argument
This might be breaking, but better do sooner than later. We can discuss with @czoido
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Merged
Member
|
This is now superseded by the 2.12 patch release in #17760 can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: (Feature | Fix | Bugfix): Add doctstring for SBOM
Docs: Omit