Report remote while requesting login#17178
Merged
AbrilRBS merged 1 commit intoOct 17, 2024
Merged
Conversation
In setups with multiple remotes configured the prompt to enter a password might appear multiple times. After the first input users could deduce that the given password is wrong and in worst case start trying other ones, even if it was correct. Naming the remote name in the prompt as well will avoid such kind of confusion.
Contributor
Author
|
Member
|
Thanks a lot @marlamb for taking the time to improve this, we appreciate it :) |
AbrilRBS
approved these changes
Oct 16, 2024
memsharded
approved these changes
Oct 16, 2024
memsharded
left a comment
Member
There was a problem hiding this comment.
Thanks very much for your contribution.
This is indeed a good addition, totally makes sense, lets get it for next release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Add remote name to login prompt.
Docs: Omit
In setups with multiple remotes configured the prompt to enter a password might appear multiple times. After the first input users could deduce that the given password is wrong and in worst case start trying other ones, even if it was correct. Naming the remote name in the prompt as well will avoid such kind of confusion.