Add cmake_file_name_variants support for CMakeConfigDeps#19530
Merged
memsharded merged 13 commits intoFeb 12, 2026
Merged
Conversation
AbrilRBS
commented
Jan 29, 2026
cmake_extra_find_casing_names support for CMakeConfigDeps
AbrilRBS
commented
Jan 29, 2026
memsharded
reviewed
Jan 29, 2026
memsharded
reviewed
Jan 29, 2026
memsharded
left a comment
Member
There was a problem hiding this comment.
Now the implementation is looking better.
But I still wonder if too much. The use case for this is extremely niche. Just a couple of recipes from ConanCenter. What is the effect of creating the extra casing xxx_DIR even if the user did the override? They won't be used, but nothing will change?
Maybe not, and it is good as-is, just wondering, I have this feeling when CMakeDeps accumulated also a lot of things and maintenance became complicated.
memsharded
approved these changes
Feb 2, 2026
czoido
approved these changes
Feb 2, 2026
Contributor
|
I'm ok with the name of the config but maybe it's a bit long, some alternatives could be:
but It's not that I love any of these too... |
cmake_extra_find_casing_names support for CMakeConfigDepscmake_file_name_variants support for CMakeConfigDeps
memsharded
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Add
cmake_file_name_variantssupport toCMakeConfigDepsto allow packages to define additional lower/upper-case variants that consumers may use when callingfind_package.Docs: conan-io/docs#4384