Fix CMake escape error#19706
Merged
Merged
Conversation
Merged
franramirez688
approved these changes
Mar 4, 2026
AbrilRBS
approved these changes
Mar 4, 2026
aagor
reviewed
Mar 4, 2026
| f' got {type(value)}') | ||
|
|
||
|
|
||
| def cmake_escape_value(v): |
Contributor
There was a problem hiding this comment.
I suggest to revert the whole function to the old version (for now).
czoido
approved these changes
Mar 5, 2026
memsharded
added a commit
to memsharded/conan
that referenced
this pull request
Apr 22, 2026
* fix cmake escape error * remove patch * revert * revert cmake_escape_value()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Revert regression in escaping
CMakeToolchain.variables, those variables will not be automatically escaped.Docs: Omit
For: #19642 (comment)