Meson: fix meson_lib missing deps, meson_exe layout & install verbosity#19918
Conversation
memsharded
left a comment
There was a problem hiding this comment.
Looks good, maybe at least some integration test that checks the new {{as_name(require)}} = dependency('{{as_name(require)}}', required: true) logic?
Because the layout() would be at least tested not to break by functional tests
|
|
||
| def layout(self): | ||
| self.folders.build = "build" | ||
| basic_layout(self) |
There was a problem hiding this comment.
This changes the folder to be build-debug and build-release, is it intended?
There was a problem hiding this comment.
Yes! Without a basic_layout, all generators and meson cache/files were being created in the root, constantly dirtying it
Okay, I can do it, but it is just a copy from |
No, better do not add new functional tests for this, I was thinking of a fast integration one, because I thought there were already some integration tests for this, but there isn't, so probably not worth it. |
|
Yes, that is what I was wondering. I did not see any test which were testing a meson_lib/meson_exe using |
$ conan new meson_lib -d name="liba" -d version=1.0 -o liba$ conan new meson_lib -d name="libb" -d version=1.0 -d requires=liba/1.0 -o libb$ conan new meson_exe -d name="consumer" -d version=1.0 -d requires="libb/1.0" -o consumer$ conan export liba$ conan export libb$ conan build consumer -b missing`./consumer/build-release/consumer
liba/1.0: Hello World Release!
liba/1.0: __aarch64__ defined
liba/1.0: __cplusplus201703
liba/1.0: __GNUC__4
liba/1.0: __GNUC_MINOR__2
liba/1.0: __clang_major__17
liba/1.0: __apple_build_version__17000604
libb/1.0: Hello World Release!
libb/1.0: __aarch64__ defined
libb/1.0: __cplusplus201703
libb/1.0: __GNUC__4
libb/1.0: __GNUC_MINOR__2
libb/1.0: __clang_major__17
libb/1.0: __apple_build_version__17000604
consumer/1.0: Hello World Release!
consumer/1.0: __aarch64__ defined
consumer/1.0: __cplusplus201703
consumer/1.0: __GNUC__4
consumer/1.0: __GNUC_MINOR__2
consumer/1.0: __clang_major__17
consumer/1.0: __apple_build_version__17000604
consumer/1.0 test_package
|
Changelog: Fix: Fix
meson_libmissing deps,meson_exelayout & install verbosity.Docs: omit