Explicit architecture suffix for multiarch on the build machine (e.g. libc6:i386)#20047
Draft
davidsanfal wants to merge 3 commits into
Draft
Explicit architecture suffix for multiarch on the build machine (e.g. libc6:i386)#20047davidsanfal wants to merge 3 commits into
davidsanfal wants to merge 3 commits into
Conversation
memsharded
approved these changes
Jun 10, 2026
memsharded
left a comment
Member
There was a problem hiding this comment.
Overall it looks good. I don't see any risk of breaking, as previously packages with separators as : were not allowed/working, is there any other potential risk?
| "riscv64": "riscv64"} if arch_names is None else arch_names | ||
| self._arch_separator = "." | ||
|
|
||
| def _parse_explicit_arch_suffix(self, name): |
Member
There was a problem hiding this comment.
The 2 implementations of this method look very very similar. Why this one has validation of _arch_names and the previous one doesn't? Maybe this could be the default implementation of the method in the base class?
| arch_separator = self._arch_separator | ||
| arch_name = explicit_arch | ||
|
|
||
| if not arch_name and self._arch in self._arch_names and cross_building(self._conanfile) and host_package: |
Member
There was a problem hiding this comment.
Maybe here an else self._arch ... is more evident flow?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Support explicit architecture suffixes in system package names with host_package=False, so check/install correctly detect already-installed packages on native builds.
Docs: TODO