✅ Deploy Preview for conda-lock ready!

Name	Link
🔨 Latest commit	96c1326
🔍 Latest deploy log	https://app.netlify.com/sites/conda-lock/deploys/662bc8a0d800b600082a96d0
😎 Deploy Preview	https://deploy-preview-629--conda-lock.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Thanks so much @sfinkens for all your work on this! I like your approach.

1. It's fine as-is. I would really like to get the test suite refactored, and I'd be very grateful for any help you could provide. But I see that as a different issue.
2. I think it's fine for now. We could support it later if there's demand for it, but I suspect it isn't worth the effort.
3. Looks good to me.
4. As for the mypy issue in particular, I think all you need to do is to inline _dependency_provides_hash. Then you should be solid from a typing perspective. Could you be more specific about the inconsistency you're concerned about? (I'm sure you're thinking more deeply that I am on this subject.)

1. Ok, I'll put that on my "spare time" list :)
2. Agreed!
3. Ok!
4. In pypi_solver.get_requirements() there's an if block

def get_requirements():
    if op.package.source_type == "url":
        hash = ...  # variant 1
    elif op.package.source_type == "git":
        hash = ...  # variant 2
    else:
        hash = ...  # variant 3

and I was wondering if that logic could be delegated to the corresponding dependency classes

def get_requirements():
    hash = op.package.dependency.get_hash_model()
    # ...

class PoetryURLDependency:
    def get_hash_model()
        # variant 1

class PoetryVCSDependency:
    def get_hash_model():
        # variant 2

class PoetryDependencyWithHash:
    def get_hash_model():
         # variant 3

We couldn't get rid of the if block entirely, but maybe make it a bit smaller. Then mypy wouldn't complain anymore, because every dependency class provides that method. But now that I think about it, that's maybe beyond the scope of this PR.

Regarding 4. I find the if nice and explicit. Unless there's a really clean and obvious class hierarchy, tucking away logic into class methods seems unnecessarily indirect. Since this is all a bit of a hack, I'd rather have that hack in one place upfront in the if block, if that makes any sense. :)

Since this is all a bit of a hack, I'd rather have that hack in one place

Good point! 👍