Skip to content

Network interface name matters, updated #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dcbw merged 4 commits into from
May 31, 2018
Merged

Network interface name matters, updated #557

dcbw merged 4 commits into from
May 31, 2018

Conversation

@dcbw
Copy link
Member

@dcbw dcbw commented May 30, 2018 •
edited by bboreham
Loading

This is to fix up #551 against the latest code updates.

@dcbw dcbw closed this May 30, 2018
@dcbw dcbw reopened this May 30, 2018
@bboreham bboreham changed the title If name matters Network interface name matters, updated May 30, 2018
@bboreham bboreham mentioned this pull request May 30, 2018
Closed
@MikeSpreitzer
Copy link
Contributor

MikeSpreitzer commented May 30, 2018

@bboreham thanks for the update.

/LGTM
(not sure if that's formally proper or matters in this case.)

@dcbw
Copy link
Member Author

dcbw commented May 30, 2018

/lgtm

@dcbw dcbw merged commit 86431d5 into master May 31, 2018
@matthewdupre matthewdupre deleted the if-name-matters branch May 31, 2018 19:12
@squeed squeed added this to the spec v0.4.0 milestone Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@squeed squeed squeed approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

spec v0.4.0

Development

Successfully merging this pull request may close these issues.

5 participants

@dcbw @MikeSpreitzer @squeed @bboreham