Don't self-reference the x_package.go's own package in import proxy's argument types#163
Open
WilliamNHarvey wants to merge 2 commits into
Conversation
…nerating, then we don't prepend it to the type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in genimport with proxy package types.
In my example, before we would write
But after we correctly write
This frontend/backend pattern is common in golang apps that use stubbing for tests or for optional ways to implement a common backend
Happy to rip out the example and only merge the actual fix upstream if that's preferred. I didn't see an existing test otherwise