fix: avoid over-normalizing Kubernetes application ids#898
Open
immanuwell wants to merge 1 commit into
Open
Conversation
Member
|
In general, this looks good. Could you please clarify in which scenarios ReplicaSets are created directly without using Deployments? |
Contributor
Author
|
@def sorry, somehow I missed this comment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a small k8s app-id papercut. Some user-created Jobs and ReplicaSets can look generated, so Coroot could fold them into the wrong parent app. Not great.
Repro before this patch:
NewApplicationId(..., ReplicaSet, "catalog-a")becomes DeploymentcatalogNewApplicationId(..., Job, "db-migration-1")becomes CronJobdb-migrationBoth names are valid k8s object names, so this can happen in real clusters. The fix only normalizes the generated-looking forms: ReplicaSet
name-<10 hex chars>and Jobname-<10+ digits>.Tested:
go test ./model