Skip to content

Conversation

@wyattjoh
Copy link
Contributor

What does this PR do?

  • Fix CSS loading order bug
  • Remove custom CSS from admin page

How do I test this PR?

  1. Create a custom CSS file that changes something without !important.
  2. Refresh the stream, notice the change.
  3. Refresh the admin, notice no change!

@wyattjoh wyattjoh added the bug label May 31, 2018
@kgardnr kgardnr self-requested a review May 31, 2018 17:30
@cvle
Copy link
Contributor

cvle commented May 31, 2018

Does admin needs the custom css?

@kgardnr kgardnr added this to the v4.4.2 milestone May 31, 2018
@wyattjoh
Copy link
Contributor Author

Most newsrooms @cvle that I've tested their CSS on admin broke everything, as it isn't scoped to the CSS of the embed stream.

@wyattjoh wyattjoh merged commit 375ef09 into master May 31, 2018
@wyattjoh wyattjoh deleted the templates branch May 31, 2018 17:50
@kgardnr kgardnr modified the milestones: v4.4.2, v4.4.3 May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants