Skip to content

Conversation

@LeWimbes
Copy link
Contributor

@LeWimbes LeWimbes commented Mar 4, 2025

This pull request addresses two issues with the Dockerfiles:

  • CORE Versioning:
    Although the CORE_PACKAGE was specified, both Dockerfiles ended up downloading the package from the latest release. This forces users who want to build an older version to manually adjust the URL.

  • Quagga Package Cleanup:
    The quagga package was not cleaned up after installation.

@bharnden bharnden changed the base branch from master to develop March 4, 2025 15:46
@bharnden bharnden self-assigned this Mar 4, 2025
@bharnden
Copy link
Contributor

bharnden commented Mar 4, 2025

The package version changes are a good change and definitely generally helpful. Assuming everything else holds up, worth a shot.

In my testing the OSPF MDR debian package was bad and not building correctly to provide a valid install, which is why it was not being used. This will likely change in the somewhat near future with a shift away from OSPF MDR. A package is built and can be installed, but it is missing needed binaries.

I have not seen any issues related to using apt-get in this way. A source here notes support for this type of interaction was added in APT 1.1 (see release announcement).

Removing a file copied in a previous step doesn't have any impact on the image size, but would not hurt to remove it.

@LeWimbes LeWimbes force-pushed the fix_improve_dockerfile branch from 756b50f to dc8a774 Compare March 4, 2025 16:47
@LeWimbes
Copy link
Contributor Author

LeWimbes commented Mar 4, 2025

Regarding OSPF: Thanks for the insight. I assumed it was just an oversight not to use the package generated in the first stage of the Dockerfile.

I was also wondering why apt-get wasn't working for me, as I thought I had used it before for installing local packages. After your comment, I took a closer look and discovered that the issue was actually due to a typo I initially made in the quagga filename, which led apt-get to throw an Unsupported file ... error. My apologies for the confusion.

I've now reversed the changes related to OSPF and apt-get. The PR now only includes the modifications to download the CORE packages from the correct release and to remove the quagga packages after installation.

@LeWimbes LeWimbes changed the title Fix Ubuntu Dockerfile and improve both Improve Dockerfiles Mar 4, 2025
@bharnden bharnden merged commit fd05c29 into coreemu:develop Apr 7, 2025
@LeWimbes LeWimbes deleted the fix_improve_dockerfile branch April 8, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants