feat: refactoring (944110 PL1) #3715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Failing tests are including keywords in multiple XML attributes. I found only one exploits which is splitted accross multiple XML elements/attributes and it is going to be catched also after my modification to the rule. Was not able to find a non-XML exploit which is splitted into multiple variables. Solutions:
|
Member
Author
|
I would go with 2. |
Member
|
After reading (and re-reading) this one, and the exploit you mentioned there, idk if just going with 1) instead, and just document it. But 2) sounds good also, if you think it adds value. |
Member
Author
|
@fzipi Can you look at it now? Thnx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule
944110is matching same variables in both main and chained rules. This is:The list of variables in the chained rule should be replaced with a MATCHED_VARS variable as we only need to match against variables matched by the main rule. Also, the current behavior may create more FPs as main rule may match variable1 and the chained rule may match variable2 (which wasn't matched by main rule).
Also, the chained rule was missing
t:lowercaseso it was possible to bypass this check.