Skip to content

Conversation

@airween
Copy link
Contributor

@airween airween commented Sep 22, 2024

Solves #3764.

@airween airween requested a review from fzipi September 22, 2024 16:46
@fzipi fzipi changed the title feat: Check if rule use TX:N target without capture action feat: check if rule use TX:N target without capture action Sep 23, 2024
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good.

I think we should move the utils out of this repo. We cannot test them properly, and they are related but they could be siblings to other major tools like ftw or the toolchain. Maybe having a linting tool that we can use as an action?

@fzipi
Copy link
Member

fzipi commented Sep 24, 2024

BTW, with this one applied there are no issues with the rules code, right?

@airween
Copy link
Contributor Author

airween commented Oct 2, 2024

BTW, with this one applied there are no issues with the rules code, right?

Yes, there isn't any issue regarding the rules.

@airween airween added this pull request to the merge queue Oct 2, 2024
Merged via the queue into coreruleset:main with commit 0a2588e Oct 2, 2024
@airween airween deleted the v4/checkcapture branch October 2, 2024 14:27
@airween
Copy link
Contributor Author

airween commented Oct 2, 2024

The code looks good.

I think we should move the utils out of this repo. We cannot test them properly, and they are related but they could be siblings to other major tools like ftw or the toolchain. Maybe having a linting tool that we can use as an action?

It's up to us - btw I usually used to use this tool after all modification and it helps me a lot. I mean it's comfortable that I can run from the same place as the rules are. But we can move that to a standalone repository (when I started to work on it that was the plan - this is why I created a CHANGLOG inside the directory)

@fzipi fzipi added the release:ignore Ignore for changelog release label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:ignore Ignore for changelog release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants