Skip to content

refactor: 3835 pylint interventions #3837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fzipi merged 2 commits into from
Sep 30, 2024
Merged

refactor: 3835 pylint interventions #3837

fzipi merged 2 commits into from
Sep 30, 2024

Conversation

@evidencebp
Copy link
Contributor

@evidencebp evidencebp commented Sep 30, 2024

Fixing two alerts for pylint intervention experiment
The plan was 3 interventions

Changes are minor

  • The first long line represented the output and should stay as is
  • Unneeded parentheses were removed when calling the del keyword
  • Add line breaks to two too long lines making them shorter

Each intervention was done in a dedicated commit with a message explaining it.

@fzipi

@evidencebp
util\crs-rules-check\rules-check.py superfluous-parens
1643f7f 
Code calls  del(self.undef_txvars[-1])
While it works, while it works, del is a python keyword and not a function. Hence it is better to call del self.undef_txvars[-1]

See https://www.w3schools.com/python/ref_keyword_del.asp
@evidencebp
util\change-version\change-version.py line-too-long
5aa6428 
Added newline to make two lines shorter
@evidencebp evidencebp mentioned this pull request Sep 30, 2024
Closed
@evidencebp evidencebp changed the title 3835 pylint interventions refactor:3835 pylint interventions Sep 30, 2024
@M4tteoP M4tteoP changed the title refactor:3835 pylint interventions refactor: 3835 pylint interventions Sep 30, 2024
@fzipi
Copy link
Member

fzipi commented Sep 30, 2024

Fixes #3835

@fzipi
Copy link
Member

fzipi commented Sep 30, 2024

Thanks for the fixes @evidencebp!

@fzipi fzipi added this pull request to the merge queue Sep 30, 2024
Merged via the queue into coreruleset:main with commit a6036b9 Sep 30, 2024
@fzipi fzipi mentioned this pull request Oct 7, 2024
Closed
This was referenced Oct 8, 2024
Closed
Open
Closed
@fzipi fzipi added the release:ignore Ignore for changelog release label Oct 9, 2024
This was referenced Oct 14, 2024
Open
Closed
Closed
Closed
Closed
This was referenced Nov 3, 2024
Open
Open
Open
Closed
Closed
This was referenced Nov 10, 2024
Closed
Closed
Closed
Closed
This was referenced Nov 13, 2024
Closed
Closed
Open
Open
Closed
Open
Closed
Closed
Closed
This was referenced Nov 20, 2024
Open
Closed
Open
Open
Open
Open
Open
Closed
Open
Closed
Closed
Open
This was referenced Nov 27, 2024
Open
Closed
Open
Closed
Closed
This was referenced Dec 28, 2024
Open
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fzipi fzipi fzipi approved these changes

Assignees

No one assigned

Labels

release:ignore Ignore for changelog release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@evidencebp @fzipi