Migrate the AccessList from ethcontract to alloy #3985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinquaXD
reviewed
Dec 19, 2025
Comment on lines
225
to
231
| let tx = match self.simulation_gas_price().await { | ||
| Some(gas_price) => { | ||
| let gas_price = gas_price.try_into().map_err(|err| { | ||
| Error::GasPrice(anyhow!("failed to convert gas_limit to u128: {err:?}")) | ||
| })?; | ||
|
|
||
| tx.with_gas_price(gas_price) |
Contributor
There was a problem hiding this comment.
I think there are not many calls to simulation_gas_price. Might be easier to move this error handling into that call already and update the callers accordingly.
Contributor
Author
There was a problem hiding this comment.
Done, not 100% sure if the log I left should be debug or warn though
MartinquaXD
approved these changes
Dec 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates the AccessList code from ethcontract to alloy; this has been partially migrated by the previous #3995
Changes
How to test
Existing tests