Revert use of WeakReferences for SbtUpdateReport cached values
#564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes sbt/sbt#8150
In #563, I chose to wrap the cache map's values in
WeakReferencebecause in heap dumps I was seeing a lot ofsbt.librarymanagement.Artifactandsbt.librarymanagement.ModuleIDs mentioned as values thatSbtUpdateReportwas referencing. UsingWeakReferencecaused them to go away.The result of using it is that the map's values could be garbage collected before its keys, leading to map entries with
nullvalues and causingNullPointerExceptions.Looking more closely at the heap dumps, I don't think the
Artifacts andModuleIDs are part of the original memory leak issue, so it should be fine to removeWeakReference. WithoutWeakReferencethe number of them doesn't grow linearly with the number of updates, nor does the retained heap ofSbtUpdateReport.@eed3si9n do you mind taking a look?